Skip to content

Use version_compare to compare version strings correctly#18173

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
schmengler:fix-upgrade-message
Oct 3, 2018
Merged

Use version_compare to compare version strings correctly#18173
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
schmengler:fix-upgrade-message

Conversation

@schmengler
Copy link
Copy Markdown
Contributor

@schmengler schmengler commented Sep 21, 2018

Description

Version numbers were compared with regular alphanumeric string comparison <, which results in 1.10 < 1.9. Instead, version_compare should be used

Manual testing scenarios

  1. Update a module from version 1.9.0 to 1.10.0 and open the shop in the browser
  2. Expected message: "run setup:upgrade", not "run composer install"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Sep 21, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Sep 21, 2018

Hi @schmengler. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev ihor-sviziev self-assigned this Sep 23, 2018
@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Sep 23, 2018

Hi @schmengler,
Good catch!
Please sign CLA, otherwise we can't process your pull request

@slavvka
Copy link
Copy Markdown
Member

slavvka commented Sep 26, 2018

Hi @schmengler, we need the fix to be delivered also to 2.2-develop branch so please don't forget to port this PR to 2.2-develop; you can do it easily using the Porting Tool, https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Sep 27, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Sep 27, 2018

Hi @slavvka, thank you for the review.
ENGCOM-3051 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 08e1562 into magento:2.3-develop Oct 3, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 3, 2018
ENGCOM-3051: Use version_compare to compare version strings correctly #…
15a96a9 
…18173
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 3, 2018

Hi @schmengler. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@lewisvoncken lewisvoncken mentioned this pull request Oct 6, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slavvka slavvka slavvka approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@slavvka slavvka

Labels

Component: Framework/Module Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@schmengler @magento-cicd2 @magento-engcom-team @ihor-sviziev @slavvka